FAST EXP ER command support - breaking change on lighting code#1945
Draft
bosh wants to merge 15 commits intomissionpinball:devfrom
Draft
FAST EXP ER command support - breaking change on lighting code#1945bosh wants to merge 15 commits intomissionpinball:devfrom
bosh wants to merge 15 commits intomissionpinball:devfrom
Conversation
a6f249a to
38d35fd
Compare
fec5003 to
de6cd0d
Compare
984b606 to
75074d5
Compare
…h > 1 carry value though this should never happen in practice since we only call loop range(3) times, so +0, +1, and +2. Even a 4-channel light could only carry once, so really this should only matter in the 5+ channel case (or perhaps if you can start with an offset of +3, which really should be a carry+1 with 0 offset
for readability. The config params are generally pulled out inside the initialize in these, rather than from the self config reference within the function -- this is intentional to try and keep config reading inside initialize itself
…rought execution order for readability
to better orient the seams with the data structures and relevancy
…r ER command support .44 provided the ER command, but .48 provides 128 as the light-limit-per-header and has extended support for RGB-RGBW mixed chains
required an ER: message processor in order to not block past getting the ER:P response
under the hood the light breakouts are considered "local breakouts", so the dev will define light overrides there, not inside the "breakouts" config
added a new config option, which is 1-based (since LED numbers in FAST are 1 based) and support in ER command when setting mixed mode
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Using the ER command as implemented requires EXP firmware 0.48, so that's our minimum now, which is breaking.
We could introduce more granular version checking etc, but I don't think it's worth it. The config_spec did change, which is breaking as well, but probably nobody had that defined at all (since it didnt do anything).
Documentation is on a mpf-docs branch already, testing on a couple live machines will happen soon (but the ER and RD command logs, plus my basic live testing has suggested to me that it's working well :) ).